Skip to content

Conversation

@lenemter
Copy link
Member

No description provided.

@lenemter lenemter requested a review from a team February 16, 2025 11:55
@lenemter lenemter added this to OS 9 Mar 1, 2025
@lenemter lenemter moved this to Needs Review in OS 9 Mar 1, 2025
@leolost2605 leolost2605 requested a review from a team March 2, 2025 13:59
@lenemter
Copy link
Member Author

lenemter commented Mar 8, 2025

@leolost2605 I removed delay because it is not needed anymore. I have no idea where it came from since mutter is responsible for dwell click, not libinput. Also gnome-shell doesn't add any delay either, so I don't think UX input is needed here

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenemter ok yeah I just wasn't sure because I don't use this feature but the change was quite noticeably so I thought there must've been a reason for it.
Anyways the changes LGTM :)

@davidmhewitt
Copy link
Member

#1152

@lenemter
Copy link
Member Author

lenemter commented Mar 9, 2025

@davidmhewitt Thanks for linking that, I totally missed this issue

@lenemter lenemter closed this Mar 9, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Done in OS 9 Mar 9, 2025
@lenemter lenemter deleted the lenemter/dwellclicktimer-remove-timmeout branch March 9, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants